Review Request: Refactor ErrorDictionary to be a namespace and carrying Tp constants
Dario Freddi
drf at kde.org
Fri Nov 18 18:48:05 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103178/
-----------------------------------------------------------
(Updated Nov. 18, 2011, 6:48 p.m.)
Review request for Telepathy and Martin Klapetek.
Changes
-------
Added Martin to reviewers
Description
-------
Instead of having a singleton and a hash, simply return the string when needed - single apps or library initializers should take care of loading catalogs. Also, no moar magic strings, but constants for your wicked minds.
Diffs
-----
error-dictionary.h ee92d12
error-dictionary.cpp 5f84b7b
Diff: http://git.reviewboard.kde.org/r/103178/diff/diff
Testing
-------
Thanks,
Dario Freddi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111118/990c378e/attachment.html>
More information about the KDE-Telepathy
mailing list