Review Request: Use dialog-less setup for salut account

Martin Klapetek martin.klapetek at gmail.com
Mon Nov 14 12:07:15 UTC 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103117/
-----------------------------------------------------------

(Updated Nov. 14, 2011, 12:07 p.m.)


Review request for Telepathy and Dario Freddi.


Changes
-------

Fixed all the raised issues.


Description
-------

This tries to automate the setup of salut account. It takes first and last name from KUser, splits them by the last space (the issues have been already discussed) and displays a KMessageWidget (that's why the kdelibs min version bump to 4.7). This auto-closes after 8 secs, displaying a circular countdown. User still has a choice to modify the data by using the dialog.


Diffs (updated)
-----

  CMakeLists.txt 3690e31 
  src/CMakeLists.txt 67de5e1 
  src/kcm-telepathy-accounts.h 1e8d92b 
  src/kcm-telepathy-accounts.cpp 23420fa 
  src/main-widget.ui f333271 
  src/salut-details-dialog.h PRE-CREATION 
  src/salut-details-dialog.cpp PRE-CREATION 
  src/salut-enable-dialog.h ca15d59 
  src/salut-enable-dialog.cpp d1333a4 
  src/salut-enabler.h PRE-CREATION 
  src/salut-enabler.cpp PRE-CREATION 
  src/salut-message-widget.h PRE-CREATION 
  src/salut-message-widget.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/103117/diff/diff


Testing
-------

Works.


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111114/509ddd5f/attachment.html>


More information about the KDE-Telepathy mailing list