Review Request: Add "Remove user from this group" and use Konvi's url detector in the context menu links menu

[Martin Klapetek]

> On Nov. 12, 2011, 1 p.m., David Edmundson wrote:
> > main-widget.cpp, line 889
> > <http://git.reviewboard.kde.org/r/103118/diff/1/?file=40874#file40874line889>
> >
> >     QAction -> KAction
> >     
> >     Fix your Capitalisation. Either have It all Title case or Not.
> >     (Actually I think UI rules state it should be sentence case.)

This is actually according to KDE HIG:

Capitalize all words except for:
...
 - Prepositions having less than five letters, (e.g. "for", "in", "with" or "to", but "From" or "Under")
...

See http://techbase.kde.org/Projects/Usability/HIG/Capitalization


> On Nov. 12, 2011, 1 p.m., David Edmundson wrote:
> > main-widget.cpp, line 927
> > <http://git.reviewboard.kde.org/r/103118/diff/1/?file=40874#file40874line927>
> >
> >     Telepathy does support blocking. In fact we use it in 'remove'. (there was an issue in butterfly at one point, but that's fairly irrelevant now.)
> >     
> >     Can we sort this out in a separate commit sometime.
> >     
> >

Ah, that's an old code done by comawhite I think, I'll remove the comment.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103118/#review8137
-----------------------------------------------------------


On Nov. 12, 2011, 12:31 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103118/
> -----------------------------------------------------------
> 
> (Updated Nov. 12, 2011, 12:31 p.m.)
> 
> 
> Review request for Telepathy and Dario Freddi.
> 
> 
> Description
> -------
> 
> As description
> 
> 
> Diffs
> -----
> 
>   main-widget.h f602a3a 
>   main-widget.cpp ab37eb0 
> 
> Diff: http://git.reviewboard.kde.org/r/103118/diff/diff
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111112/680c8b53/attachment.html>