Review Request: Circular countdown widget

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103094/#review8064
-----------------------------------------------------------


Looks very good, just a few comments


circular-countdown.h
<http://git.reviewboard.kde.org/r/103094/#comment6946>

    Perhaps you might add also "int duration() const"



circular-countdown.h
<http://git.reviewboard.kde.org/r/103094/#comment6944>

    I'd use for this signal "timeout()" (same name used by QTimer) or "finished()" (same name used by QTimeLine)



circular-countdown.h
<http://git.reviewboard.kde.org/r/103094/#comment6943>

    Being a very good candidate to be in a library, private members should be in a private class



circular-countdown.cpp
<http://git.reviewboard.kde.org/r/103094/#comment6942>

    Instead of setMaximumSize you should reimplement sizeHint and call setSizePolicy (see QWidget documentation[1])
    
    [1]http://doc.qt.nokia.com/stable/qwidget.html



circular-countdown.cpp
<http://git.reviewboard.kde.org/r/103094/#comment6940>

    It took some time to understand this, found the meaning here [1], perhaps use 360*16 and add a comment...
    Anyway 5760 frames in 5000 msecs looks a little unreasonable, do you know if QTimeLine+QPainter can handle this automatically? Otherwise you should limit the framerate somehow...
    
    [1]http://doc.qt.nokia.com/stable/qpainter.html#drawPie



circular-countdown.cpp
<http://git.reviewboard.kde.org/r/103094/#comment6941>

    Same here (90*16 requires at least a comment)


- Daniele Elmo Domenichelli


On Nov. 9, 2011, 5:02 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103094/
> -----------------------------------------------------------
> 
> (Updated Nov. 9, 2011, 5:02 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Description
> -------
> 
> Little circular countdown widget that can be used throughout components (currently accounts-kcm, planned for contact list). See screenshot - the black frame (KMessageWidget) top right corner. 
> 
> 
> Diffs
> -----
> 
>   circular-countdown.h PRE-CREATION 
>   circular-countdown.cpp PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/103094/diff/diff
> 
> 
> Testing
> -------
> 
> It's ok.
> 
> 
> Screenshots
> -----------
> 
> Circular countdown
>   http://git.reviewboard.kde.org/r/103094/s/332/
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-telepathy/attachments/20111109/b0bab282/attachment-0001.html>