Review Request: Replace passing round QModelIndexes with ContactModelItem* this fixes various crashes when using proxy models.

David Edmundson kde at davidedmundson.co.uk
Fri May 27 17:00:15 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101448/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Replace passing round QModelIndexes with ContactModelItem* this fixes various crashes when using proxy models.

BUG: 274148
BUG: 274160

Grouped related slot in main widget header declaration


Diffs
-----

  accounts-model.h 0eda7f406dde9b3c1443fb0f4b1656fbb878efad 
  accounts-model.cpp c342c5bfcb89e1d9778556cbd4604f8e03830420 
  contact-overlays.h c858b7309c04c4a05f3ddc9e2c1b7c7da1d9d239 
  contact-overlays.cpp ef85634ec4b691e8f37ca288ef2f72764cef44fe 
  main-widget.h c103a66e4c92b93a933fe02c82b5462c09740e85 
  main-widget.cpp b929572ff47e7fc4a34e385525d0aab458909ffb 

Diff: http://git.reviewboard.kde.org/r/101448/diff


Testing
-------


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110527/78999a08/attachment.htm 


More information about the KDE-Telepathy mailing list