Review Request: Alternate view delegate with delegate refactoring

David Edmundson kde at davidedmundson.co.uk
Fri May 20 01:15:03 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101389/#review3410
-----------------------------------------------------------

Ship it!


- David


On May 19, 2011, 12:04 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101389/
> -----------------------------------------------------------
> 
> (Updated May 19, 2011, 12:04 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch adds a switch for an alt. delegate, which is more compact than the original one. Also it refactors the delegate code - now there's a base class, which takes care of the tooltip and of the shared painting stuff (groups etc), but can be easily overriden by custom painting. This class can be used for other possible delegates.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 919df77 
>   abstract-contact-delegate.h PRE-CREATION 
>   abstract-contact-delegate.cpp PRE-CREATION 
>   contact-delegate-compact.h PRE-CREATION 
>   contact-delegate-compact.cpp PRE-CREATION 
>   contact-delegate.h 46fea76 
>   contact-delegate.cpp 209e715 
>   contact-overlays.h c858b73 
>   main-widget.h 7a5e417 
>   main-widget.cpp 20e8003 
> 
> Diff: http://git.reviewboard.kde.org/r/101389/diff
> 
> 
> Testing
> -------
> 
> Switched the delegate few times, all is ok.
> 
> 
> Screenshots
> -----------
> 
> New delegate screenshot
>   http://git.reviewboard.kde.org/r/101389/s/169/
> New contact tooltip
>   http://git.reviewboard.kde.org/r/101389/s/170/
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110519/e0ab1168/attachment.htm 


More information about the KDE-Telepathy mailing list