Review Request: Use all groups from all protocols

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101344/#review3380
-----------------------------------------------------------



main-widget.cpp
<http://git.reviewboard.kde.org/r/101344/#comment2819>

    I think this would be a great commit message, but it is not much use in the code :)



main-widget.cpp
<http://git.reviewboard.kde.org/r/101344/#comment2820>

    You're missing a + here, ie. groupList += ..., otherwise it will always overwrite the groupList. So use either append() or << operator.


- Martin


On May 18, 2011, 12:35 p.m., Keith Rusler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101344/
> -----------------------------------------------------------
> 
> (Updated May 18, 2011, 12:35 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Search through all the available accounts to retrieve the contact
> groups that are available to us then we append them together so
> that the user can move contacts all to the same groups etc instead of
> what we current had that would only move them between groups that only
> that contact had for that protocol.
> 
> 
> This addresses bug 272475.
>     http://bugs.kde.org/show_bug.cgi?id=272475
> 
> 
> Diffs
> -----
> 
>   main-widget.h 7a5e417 
>   main-widget.cpp 20e8003 
> 
> Diff: http://git.reviewboard.kde.org/r/101344/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Keith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110518/0569a30d/attachment.htm