Review Request: This patch will check if no accounts will be present then an dialog box will be opened telling no accounts found and giving an option to create on.

George Kiagiadakis kiagiadakis.george at gmail.com
Tue May 17 15:15:53 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101362/#review3359
-----------------------------------------------------------

Ship it!


Looks good to me. Just remove the extra 4 spaces on each of these lines.


main-widget.cpp
<http://git.reviewboard.kde.org/r/101362/#comment2802>

    Remove the trailing whitespace here



main-widget.cpp
<http://git.reviewboard.kde.org/r/101362/#comment2803>

    ...and here


- George


On May 17, 2011, 1:11 p.m., Tarun Mall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101362/
> -----------------------------------------------------------
> 
> (Updated May 17, 2011, 1:11 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch will check if no accounts will be present then an dialog box will be opened telling no accounts found and giving an option to create on.
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp 20e8003 
> 
> Diff: http://git.reviewboard.kde.org/r/101362/diff
> 
> 
> Testing
> -------
> 
> I tested this patch with
> 1. No accounts
> 2. Creating one account
> 3. Deleting that account and then creating one again.
> 
> 
> Thanks,
> 
> Tarun
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110517/d9f9dbf7/attachment.htm 


More information about the KDE-Telepathy mailing list