Review Request: This patch will check if no accounts will be present then an dialog box will be opened telling no accounts found and giving an option to create on.

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101362/#review3323
-----------------------------------------------------------


Better now. Two additional comments below:


main-widget.cpp
<http://git.reviewboard.kde.org/r/101362/#comment2792>

    Let's not make this a new string for the translators. Use capital F in found as in the above message.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101362/#comment2793>

    Coding style: leave spaces between function arguments.


Also please fix the remaining issues from the last review (delete the dialog if it is not used and remove the QLabel* from the class members).

- George


On May 14, 2011, 4:24 p.m., Tarun Mall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101362/
> -----------------------------------------------------------
> 
> (Updated May 14, 2011, 4:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch will check if no accounts will be present then an dialog box will be opened telling no accounts found and giving an option to create on.
> 
> 
> Diffs
> -----
> 
>   main-widget.h 7a5e417 
>   main-widget.cpp 20e8003 
> 
> Diff: http://git.reviewboard.kde.org/r/101362/diff
> 
> 
> Testing
> -------
> 
> I tested this patch with
> 1. No accounts
> 2. Creating one account
> 3. Deleting that account and then creating one again.
> 
> 
> Thanks,
> 
> Tarun
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110514/3b05525a/attachment.htm