Review Request: Use all groups from all protocols

[Keith Rusler]

> On May 12, 2011, 11:06 p.m., Martin Klapetek wrote:
> > main-widget.cpp, line 725
> > <http://git.reviewboard.kde.org/r/101344/diff/1/?file=16371#file16371line725>
> >
> >     You can actually append the groups directly to groupList, no need for the loop (for example by using "groupList << groups"). And after all the accounts are processed, you can call groupList.removeDuplicates();

Thank you. I guess I just overlooked that.


> On May 12, 2011, 11:06 p.m., Martin Klapetek wrote:
> > main-widget.cpp, line 734
> > <http://git.reviewboard.kde.org/r/101344/diff/1/?file=16371#file16371line734>
> >
> >     Whitespace leftover ;)

Ugh, I hate when those randomly pop up.


- Keith


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101344/#review3287
-----------------------------------------------------------


On May 12, 2011, 9:15 p.m., Keith Rusler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101344/
> -----------------------------------------------------------
> 
> (Updated May 12, 2011, 9:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Search through all the available accounts to retrieve the contact
> groups that are available to us then we append them together so
> that the user can move contacts all to the same groups etc instead of
> what we current had that would only move them between groups that only
> that contact had for that protocol.
> 
> 
> This addresses bug 272475.
>     http://bugs.kde.org/show_bug.cgi?id=272475
> 
> 
> Diffs
> -----
> 
>   main-widget.h 7a5e417 
>   main-widget.cpp 20e8003 
> 
> Diff: http://git.reviewboard.kde.org/r/101344/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Keith
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110514/2ec6d56a/attachment.htm