Review Request: This is the patch to enable nextTab and previousTab keyboard shortcuts for telepathy-chat-handler.

[Tarun Mall]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101355/#review3298
-----------------------------------------------------------



app/chat-window.h
<http://git.reviewboard.kde.org/r/101355/#comment2768>

    Sorry, I wasn't aware of that function, I'll change it.



app/chat-window.h
<http://git.reviewboard.kde.org/r/101355/#comment2769>

    well yeah you are definitely right. using new and not creating them on stack will keep them there.
    I thought that mentioning them in header file will give someone idea about these variables.
    I'll change it too.
    



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/101355/#comment2770>

    sure I'll do this as well.


- Tarun


On May 13, 2011, 1:54 p.m., Tarun Mall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101355/
> -----------------------------------------------------------
> 
> (Updated May 13, 2011, 1:54 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> The patch here will enable:
> Ctrl+Tab -> for next tab
> Ctrl+shift+Tab -> for previous tab
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h f9c07da 
>   app/chat-window.cpp 149608d 
> 
> Diff: http://git.reviewboard.kde.org/r/101355/diff
> 
> 
> Testing
> -------
> 
> Tested with 1-2 and more number of tabs open.
> 
> 
> Thanks,
> 
> Tarun
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110513/05a3ce4a/attachment-0001.htm