Review Request: Fix for bug https://bugs.kde.org/show_bug.cgi?id=272098

[Tarun Mall]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101352/
-----------------------------------------------------------

(Updated May 13, 2011, 10:59 a.m.)


Review request for Telepathy.


Changes
-------

I tried to follow alphabetical order for placing function and their declarations.
Placed KStandardAction with the group of other KStandardAction.
One whitespace seems good between private slots and public slots, still please comment if I should remove it.


Summary
-------

This is the fix for bug https://bugs.kde.org/show_bug.cgi?id=272098


This addresses bug https://bugs.kde.org/show_bug.cgi?id=272098.
    http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=272098


Diffs (updated)
-----

  app/chat-window.h 62ccdd5 
  app/chat-window.cpp a456e44 

Diff: http://git.reviewboard.kde.org/r/101352/diff


Testing
-------

I tested it with one tab open, more than one tab open.
Tabs open but not in focus and No tabs are open.
Working fine with all the test cases.


Thanks,

Tarun

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110513/fe282d20/attachment-0001.htm