Review Request: Fix for bug https://bugs.kde.org/show_bug.cgi?id=272098

[David Edmundson]

> On May 13, 2011, 10:41 a.m., Tarun Mall wrote:
> > app/chat-window.cpp, lines 75-79
> > <http://git.reviewboard.kde.org/r/101352/diff/1/?file=16407#file16407line75>
> >
> >     I used removeTab because developer used removeTab method for closing tabs, I thought its better to reuse developers method. Still if required I'll use close();

I agree with you. Use of removeTab seems to make sense. It tidies up deleting the widget and such. 

Leave it as you've done it.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101352/#review3291
-----------------------------------------------------------


On May 13, 2011, 10:12 a.m., Tarun Mall wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101352/
> -----------------------------------------------------------
> 
> (Updated May 13, 2011, 10:12 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This is the fix for bug https://bugs.kde.org/show_bug.cgi?id=272098
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=272098.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=272098
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 62ccdd5 
>   app/chat-window.cpp a456e44 
> 
> Diff: http://git.reviewboard.kde.org/r/101352/diff
> 
> 
> Testing
> -------
> 
> I tested it with one tab open, more than one tab open.
> Tabs open but not in focus and No tabs are open.
> Working fine with all the test cases.
> 
> 
> Thanks,
> 
> Tarun
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110513/bd5800e7/attachment.htm