Review Request: Switch error/info messages to KNotification

Francesco Nwokeka francesco.nwokeka at gmail.com
Sat May 7 13:10:05 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101309/#review3198
-----------------------------------------------------------

Ship it!


Looks cool to me

- Francesco


On May 6, 2011, 1:56 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101309/
> -----------------------------------------------------------
> 
> (Updated May 6, 2011, 1:56 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This removes the custom msgFrame and uses KNotification instead.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b68d136 
>   main-widget.cpp 2a00fab 
>   telepathy-kde-contactlist.notifyrc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101309/diff
> 
> 
> Testing
> -------
> 
> Caused some error and Plasma notification showed up.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110507/4509139a/attachment.htm 


More information about the KDE-Telepathy mailing list