Review Request: Connect connection errors in contactlist

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101303/#review3196
-----------------------------------------------------------


Since you haven't shipped it yet, I have two suggestions for better strings. I've done some testing with plasma popups and it's just not good when it shows you "Network error" :) So, we should extend these messages a little and add some hints for the user to make a really good error messages. See the comments below. Also, can a native english-speaker check it? ;)


main-widget.cpp
<http://git.reviewboard.kde.org/r/101303/#comment2715>

    This string would be better as:
    
    "Couldn't connect your %1 account: Authentication failed (did you set correct password?)"



main-widget.cpp
<http://git.reviewboard.kde.org/r/101303/#comment2716>

    "Couldn't connect your %1 account: There was a network error, check your connection."


- Martin


On May 6, 2011, 8:40 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101303/
> -----------------------------------------------------------
> 
> (Updated May 6, 2011, 8:40 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Simple patch to connect the connection errors and obtain a notification for the user so that he/she knows what's going on
> 
> 
> Diffs
> -----
> 
>   main-widget.h 396c08b 
>   main-widget.cpp 2a00fab 
> 
> Diff: http://git.reviewboard.kde.org/r/101303/diff
> 
> 
> Testing
> -------
> 
> Tried to connect to networks without password and wrong login
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110507/ebba2d57/attachment.htm