Review Request: Simplifying the pin/unpin mechanism of the filter bar
Commit Hook
null at kde.org
Thu May 5 22:42:22 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101190/#review3139
-----------------------------------------------------------
This review has been submitted with commit 7a680c668e1e93b6fcad9513de92d5875e7be22b by Rémy Greinhofer.
- Commit
On April 23, 2011, 11:38 a.m., Rémy Greinhofer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101190/
> -----------------------------------------------------------
>
> (Updated April 23, 2011, 11:38 a.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> After second though, we decided a button to pin/unpin the filter bar was not necessary. The filter bar will simply be shown if it was when the contact list was closed and vice-versa.
>
>
> Diffs
> -----
>
> filter-bar.h 2acb724
> filter-bar.cpp 1d04ca8
> main-widget.cpp 4b877ab
>
> Diff: http://git.reviewboard.kde.org/r/101190/diff
>
>
> Testing
> -------
>
> 1. Use the filter bar, close the contact list, relaunch the contact list. The filter bar is shown.
> 2. Then close the filter bar, close the contact list, relaunch the contact list. The filter bar disappeared.
>
> It works if you use the close button of the filter bar, as well as the search contact button.
>
>
> Thanks,
>
> Rémy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110505/357e38ef/attachment-0001.htm
More information about the KDE-Telepathy
mailing list