Review Request: Check for connection being valid rather than looking at the connection status before calling monitor presence.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101288/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Check for connection being valid rather than looking at the connection status before calling monitor presence.

There are times when connectionStatus is Connected, but account->connection() returns 0. This causes crashes in the old code.

Converted code to call monitorPresence when connectionChanges() not connectionStatusChanges.

Also updated monitorPresence to take a connectionPtr rather than accountPtr as it makes the code easier with this new change.


Diffs
-----

  main-widget.h c103a66e4c92b93a933fe02c82b5462c09740e85 
  main-widget.cpp b929572ff47e7fc4a34e385525d0aab458909ffb 

Diff: http://git.reviewboard.kde.org/r/101288/diff


Testing
-------

Reconnected a few accounts. Didn't crash.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110504/9b7e3156/attachment.htm