Review Request: Enable file transfer channel creation from contact list

[Martin Klapetek]

> On May 1, 2011, 10:44 p.m., Daniele Elmo Domenichelli wrote:
> > main-widget.cpp, lines 464-465
> > <http://git.reviewboard.kde.org/r/101263/diff/1/?file=15707#file15707line464>
> >
> >     This is a copy-paste from lines 445-446. :D
> >     Should I modify it before committing or leave it as it is?

No need, these lines will get modified once the groupping is merged back.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101263/#review3031
-----------------------------------------------------------


On May 1, 2011, 6:03 p.m., Daniele Elmo Domenichelli wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101263/
> -----------------------------------------------------------
> 
> (Updated May 1, 2011, 6:03 p.m.)
> 
> 
> Review request for Telepathy and Martin Klapetek.
> 
> 
> Summary
> -------
> 
> Initial implementation of file transfer channel creation from the contact list
> 
> Probably will require a fix in tp-qt4 because the URI property is not correctly set (only the filename is set), therefore the handler ignores the path the file.
> 
> 
> Diffs
> -----
> 
>   main-widget.h cfcd045201fc357093f837e3aa5f0c2d4e371d00 
>   main-widget.cpp 0781d4194aefaff679441dc43276e5765c18e19e 
> 
> Diff: http://git.reviewboard.kde.org/r/101263/diff
> 
> 
> Testing
> -------
> 
> The channel is created and received by the file transfer handler
> 
> 
> Thanks,
> 
> Daniele Elmo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110501/5c0b768c/attachment.htm