Review Request: Review Request: Re-establish chat after going offline and back online PART 4 of 3

Francesco Nwokeka francesco.nwokeka at gmail.com
Sun May 1 19:38:59 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101262/#review3016
-----------------------------------------------------------

Ship it!


Looks fine to me

- Francesco


On May 1, 2011, 11:46 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101262/
> -----------------------------------------------------------
> 
> (Updated May 1, 2011, 11:46 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Fixed a slightly oversight that Nwoki missed. Updated the channel in the contacts model when switching text channel.
> 
> 
> Diffs
> -----
> 
>   lib/channel-contact-model.h PRE-CREATION 
>   lib/channel-contact-model.cpp PRE-CREATION 
>   lib/chat-widget.cpp 148deb382f04ff0a8e3a2cdeee38e5bd308d51fb 
> 
> Diff: http://git.reviewboard.kde.org/r/101262/diff
> 
> 
> Testing
> -------
> 
> Went offline and online again, checked I still had status updated (XYZ is now Away etc) from the other contact.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110501/615afed8/attachment.htm 


More information about the KDE-Telepathy mailing list