Review Request: Tidy up the code for activating a window when a notification is clicked + fixed crash

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100990/#review2283
-----------------------------------------------------------

Ship it!


Looks ok

- Dario


On March 31, 2011, 2:39 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100990/
> -----------------------------------------------------------
> 
> (Updated March 31, 2011, 2:39 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
>  - Fixed some error catching code if(m_tabWidget) which didn't ever initialise m_tabWidget on creation.
>  - Tidied up the signals/slots (currently chat-widget was calling a slot that didn't exist, a subclass was catching it)
>  - Call setTabWidget on the ChatTab class so that it can select the active tab.
> 
> 
> Diffs
> -----
> 
>   app/chat-tab.cpp 224429b2ad7342e0ed42b492227aa2a38a46f649 
>   app/chat-window.cpp b3407db79f15632d640fc020674d6509739033bc 
>   lib/chat-widget.h dfdef64fcbebb727709f8492b4e558503ce32759 
>   lib/chat-widget.cpp 148deb382f04ff0a8e3a2cdeee38e5bd308d51fb 
> 
> Diff: http://git.reviewboard.kde.org/r/100990/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110331/7ab62192/attachment.htm