Review Request: Give more meaning to enabling/disabling accounts

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100537/#review2244
-----------------------------------------------------------

Ship it!


Given that the change has still not been marked as submitted, I'm nitpicking about code style :) Try and follow it for next patches. The patch overall looks fine


src/account-item.cpp
<http://git.reviewboard.kde.org/r/100537/#comment1896>

    Code style: if () { // Space between if and (, always use brackets



src/accounts-list-delegate.cpp
<http://git.reviewboard.kde.org/r/100537/#comment1897>

    Code style: } else {



src/accounts-list-delegate.cpp
<http://git.reviewboard.kde.org/r/100537/#comment1898>

    Code style: do not use this-> unless it is strictly required


- Dario


On March 24, 2011, 9:11 p.m., Thomas Richard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100537/
> -----------------------------------------------------------
> 
> (Updated March 24, 2011, 9:11 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Adds a tooltip to the checkbox and makes the account text italic/gray when disabled
> 
> 
> Diffs
> -----
> 
>   src/account-item.cpp 20709790b89bc79780371b7823462d00815db05c 
>   src/accounts-list-delegate.cpp fb0afbd872f928118fb71598476e34f664f22e80 
> 
> Diff: http://git.reviewboard.kde.org/r/100537/diff
> 
> 
> Testing
> -------
> 
> Enabling/disabling accounts
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/100537/s/67/
> 
> 
> Thanks,
> 
> Thomas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110330/800fe28f/attachment.htm