Review Request: Call parent when performing assignment operator
Martin Klapetek
martin.klapetek at gmail.com
Wed Mar 30 11:43:32 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100972/#review2235
-----------------------------------------------------------
lib/adium-theme-content-info.cpp
<http://git.reviewboard.kde.org/r/100972/#comment1876>
What actually happens to already allocated *d? Shouldn't this get deleted somewhere first? Like if(d) delete d;
- Martin
On March 30, 2011, 8:51 a.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100972/
> -----------------------------------------------------------
>
> (Updated March 30, 2011, 8:51 a.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Fixes a bug in which calls to
> AdiumThemeMessageInfo a = someOtherMessageInfo class failed to actually copy all the information.
>
> This appears a bug in the config window as found by Florian Reinhard: https://git.reviewboard.kde.org/r/100922/
>
>
> Diffs
> -----
>
> lib/adium-theme-content-info.cpp a5e1d6780ccf65acd70a024648955f621457eb65
> lib/adium-theme-status-info.cpp b2568e05a534f8d59bb82220043d9ff0dfb88aff
>
> Diff: http://git.reviewboard.kde.org/r/100972/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> David
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110330/231c79ae/attachment.htm
More information about the KDE-Telepathy
mailing list