Review Request: Show users in a group chat

[Martin Klapetek]

> On March 24, 2011, 7:15 a.m., Martin Klapetek wrote:
> > lib/channel-contact-model.cpp, line 75
> > <http://git.reviewboard.kde.org/r/100940/diff/1/?file=12799#file12799line75>
> >
> >     I think the default icon should be different than the same as for online presence, because if Tp can't get the presence type, there might be just something wrong with this user. I've experienced it in contact list - I have a user among my contacts, which has been invited, but haven't actually used that account, Tp then returns an unknown presence for this user. Therefore I suggest to use a different icon, for example the small yellow triangle with excl.mark to indicate that there is something wrong with this user.
> 
> David Edmundson wrote:
>     Maybe. Right now I'm just using icons straight from the icon set without any overlaying.
>     
>     Also I think it's a bit different here - if you're chatting with them, they must be in some form of 'online' state. If I remember correctly IRC always returns Presence::Unknown for all contacts.
> 
> Martin Klapetek wrote:
>     Actually I meant the icon, big icon, not overlay icons ;) Btw. isn't that IRC presence a Telepathy bug? And yes, initially they'll be online, but what if the user does something wrong later? You'll think he's still online, even though he may not be.
> 
> David Edmundson wrote:
>     Ok here's my proposed plan: I change it to the warning icon, if it becomes annoying in real life usage we change it back.

Ok, but first the Presence::Unknown returned for IRC contacts must be solved, because otherwise we'll end up with bunch of warning icons for IRC :)


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100940/#review2133
-----------------------------------------------------------


On March 24, 2011, 2:58 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100940/
> -----------------------------------------------------------
> 
> (Updated March 24, 2011, 2:58 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> If there are more than 1 other contact in a group chat show a list of these users in a sidebar.
> 
> 
> Diffs
> -----
> 
>   lib/CMakeLists.txt 5dc3f74aede922597ced7a7a2229fa141b3372ea 
>   lib/channel-contact-list.h 37f29e6305c96a1aa9f3a30a2eabb141139f33f5 
>   lib/channel-contact-list.cpp 2eccee0a852e47d90a74a518adcc9260e1c8cef7 
>   lib/channel-contact-model.h PRE-CREATION 
>   lib/channel-contact-model.cpp PRE-CREATION 
>   lib/chat-widget.cpp 6ea639b0b3696030bd76bba219522abf70aef400 
>   lib/chat-widget.ui 173e1151bf04c8573525ff193adffb7129df808a 
> 
> Diff: http://git.reviewboard.kde.org/r/100940/diff
> 
> 
> Testing
> -------
> 
> Opened a chat, saw that some people were there.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110324/7e9e9332/attachment.htm