Merging the Contact List and using reviewboard

[Martin Klapetek]

To also give my input on this - I'm all for reviewing the code before
merging, especially for bigger patches. I even try to read all reviews
myself, because it's anothet way how to learn writting better code. But on
the other hand, for small (obvious) patches I feel it's uselessly slowing
things down. But then again, some might learn even from these small reviews.
So I don't know really. I think I'll get used to whatever we'll decide here.

For now, let's focus on merging my clone repo back to the master tree. I'll
update the review diff when I'll get home later tonight, so let's start
reviewing it then.

Marty
On Mar 23, 2011 3:25 PM, "David Edmundson" <david at davidedmundson.co.uk>
wrote:
> This conversation came up in IRC and I wanted to bring it to the mailing
> list:
>
> - I want to merge Martin's contact list into the main repository.
> -Martin is worried that if he has to start going through reviewboard for
> patches it's really going to slow down development.
>
> I can see where he's coming from, when I see one line patches on
reviewboard
> it wastes my time going through sorting them out, and it does slow things
> down. Especially when everyone hacking is doing this just in the few
moments
> of their freetime.
>
> On the other hand I have fixed a lot of code in reviewboard before it's
> merged, and had a lot of my mistakes spotted too.
>
> Personally I just want his stuff merged, and I'm happy to leave the choice
> of whether to enforce reviewboard or not to the discretion of the
component
> leader.
>
> Does anyone have any thoughts?
>
> Dave
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110323/601a3781/attachment.htm