Review Request: Fix wrong message types in chat config demo window
Florian Reinhard
florian.reinhard at googlemail.com
Tue Mar 22 20:12:50 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100922/
-----------------------------------------------------------
Review request for Telepathy.
Summary
-------
Calling the constructor of AdiumThemeContentInfo a second time messes the d-Pointer, therefore we need a new method to set the messge type.
I guess that's not the C++Guru solution but works ;)
Diffs
-----
config/main-window.cpp 21bce19cf1fc8530bf457b0f808cf4df93d5d664
lib/adium-theme-message-info.h 97d93525d018a99e723589377430d51e33e1ffe3
lib/adium-theme-message-info.cpp 71597e361b515ace50c440f097e07b0a52dce919
Diff: http://git.reviewboard.kde.org/r/100922/diff
Testing
-------
see screenshots.
Screenshots
-----------
before
http://git.reviewboard.kde.org/r/100922/s/108/
after
http://git.reviewboard.kde.org/r/100922/s/109/
Thanks,
Florian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110322/bf7f930f/attachment.htm
More information about the KDE-Telepathy
mailing list