Review Request: Don't detect typing in chat-widget when we can't use it
Florian Reinhard
florian.reinhard at googlemail.com
Fri Mar 18 13:37:17 CET 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100886/
-----------------------------------------------------------
(Updated March 18, 2011, 12:37 p.m.)
Review request for Telepathy.
Changes
-------
that's what it should have looked like...
was to lazy to check the diff and forgot to fetch anongit before posting the review :/
Summary
-------
Let's save some cpu cylcles and don't detect typing in chat-widget when we can't use it.
Diffs (updated)
-----
lib/chat-widget.cpp 6ea639b0b3696030bd76bba219522abf70aef400
Diff: http://git.reviewboard.kde.org/r/100886/diff
Testing
-------
no more warnings like this on cli:
tp-qt4 0.5.11.1 WARN: TextChannel::requestChatState() used with no chat state interface
Thanks,
Florian
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110318/2889164a/attachment.htm
More information about the KDE-Telepathy
mailing list