Review Request: Move loading of fallback template from AdiumThemeView to ChatWindowStyle

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100878/#review2015
-----------------------------------------------------------

Ship it!


That looks a lot easier to read. Good refactor.

- David


On March 17, 2011, 1:19 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100878/
> -----------------------------------------------------------
> 
> (Updated March 17, 2011, 1:19 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Move loading of fallback template from AdiumThemeView to ChatWindowStyle.                                                                                                                                                     
>                                                                                                                                                                                                                                   
> Besides i did some code reformating.
> 
> 
> Diffs
> -----
> 
>   lib/chat-window-style.cpp e5003ec7acf1f02e6eed178773aafc02dad82228 
>   lib/adium-theme-view.cpp 0133f3d0309147083a91773be37d72d016ace08d 
> 
> Diff: http://git.reviewboard.kde.org/r/100878/diff
> 
> 
> Testing
> -------
> 
> * removed Template.html from the default theme
> messages start at bottom, not at top => default template.html got loaded
> 
> * removed default template.html
> => error message
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110317/9a586703/attachment.htm