Review Request: Don't crash when there's a chatStyle with no variants.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100870/#review1992
-----------------------------------------------------------


Very good spot! This was all written before we had code reviews :-P. Great work.


lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/100870/#comment1670>

    Surely in every case m_variantPath and name are already ""?
    
    (well actually they're QString() - which is a null string, but for all intents and purposes the same here)
    
    Your code is arguable clearer, though I might prefer:
    
    m_variantPath = QString(); instead. 
    
    remind me to look in the morning.


- David


On March 16, 2011, 1:07 a.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100870/
> -----------------------------------------------------------
> 
> (Updated March 16, 2011, 1:07 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Don't crash when there's a chatStyle with no variants.
> 
> 
> This addresses bug 268503.
>     http://bugs.kde.org/show_bug.cgi?id=268503
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.cpp 1eefafb5e64f31f75b21568d8924a6398dcafd25 
> 
> Diff: http://git.reviewboard.kde.org/r/100870/diff
> 
> 
> Testing
> -------
> 
> installed and used the h4x0r message Style
> http://adiumxtras.com/index.php?a=xtras&xtra_id=1907
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110316/14b33a63/attachment.htm