Review Request: Name, Comment & icon for the text-ui kcm + whitespace cleanup

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100869/#review1989
-----------------------------------------------------------

Ship it!


Thanks ever so much for doing this, I really didn't mean to miss your last review comments when I did my patch. 

- David


On March 15, 2011, 10:43 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100869/
> -----------------------------------------------------------
> 
> (Updated March 15, 2011, 10:43 p.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Summary
> -------
> 
> * use a decent icon
> * provide a name
> * provide a meaningful comment
> 
> 
> Diffs
> -----
> 
>   config/kcm_telepathy_chat_config.desktop 00522700378fc1daea0723a944e9496a95302696 
>   config/main-window.cpp 73e245417b0f1aa0841876ca4417fe3cf43161f0 
> 
> Diff: http://git.reviewboard.kde.org/r/100869/diff
> 
> 
> Testing
> -------
> 
> checked with
> kcmshell4 kcm_telepathy_accounts kcm_telepathy_chat_config
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110316/d71b97b7/attachment.htm