Review Request: Turn config app into a KCModule

[Florian Reinhard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100858/#review1954
-----------------------------------------------------------

Ship it!


compiled and tested. works! got some minor nitpicks:


config/CMakeLists.txt
<http://git.reviewboard.kde.org/r/100858/#comment1641>

    Remove space between install and bracket.



config/chatwindowconfig.ui
<http://git.reviewboard.kde.org/r/100858/#comment1642>

    Not part of the changes, but that QHBoxLayout with only one item seems to be somehow useless. I'll change that afterwards if there's no need for it that i don't see atm.



config/kcm_telepathy_chat_config.desktop
<http://git.reviewboard.kde.org/r/100858/#comment1645>

    the .desktop file needs a name "Chat Window Design", otherwise systemsettings shows kcm_telepathy_chat_config as fallback.



config/kcm_telepathy_chat_config.desktop
<http://git.reviewboard.kde.org/r/100858/#comment1643>

    Remove whitespace.



config/main-window.cpp
<http://git.reviewboard.kde.org/r/100858/#comment1644>

    Remove whitespace.


- Florian


On March 14, 2011, 7:24 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100858/
> -----------------------------------------------------------
> 
> (Updated March 14, 2011, 7:24 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Turn config app into a KCModule, changed the chat-ui app to load it when requested.
> 
> 
> This addresses bug 268136.
>     http://bugs.kde.org/show_bug.cgi?id=268136
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp c0e825c0cedba9cd32f5834edf335c414b6bc149 
>   config/CMakeLists.txt 2b944693e5fe684ccb1b426aaf7ee12f51c317a2 
>   config/chatwindowconfig.ui c0572229545287a7a2453c99d3e6046a3c51b8b3 
>   config/kcm_telepathy_chat_config.desktop PRE-CREATION 
>   config/main-window.h 4bb91477c30f15c0dc5b7f93cf0e8faf8957443d 
>   config/main-window.cpp 7e28346de2684ea356c838b1e910b18f67ceac3f 
> 
> Diff: http://git.reviewboard.kde.org/r/100858/diff
> 
> 
> Testing
> -------
> 
> Checked it loaded. Checked it still saved settings correctly
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110314/31a25f0f/attachment.htm