Review Request: Fix bug 268281 - chat windows use theme colors

[Alin Marin Elena]

A set of colours for the chat window, totally based on the pallette of the
kde theme should be a posibillity, imho.

Alin

2011/3/13 Francesco Nwokeka <francesco.nwokeka at gmail.com>

>    This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100849/
>
> On March 13th, 2011, 9:15 p.m., *David Edmundson* wrote:
>
> You can't do it like this. Sorry.
> We deliberately support pretty much every theme from the Adium website, therefore we can't  modify any theme code to make it fit what we want - as we'd have to do it for all of them which doesn't make sense.
>
> Besides: Fully customisable background support is both planned and do-able.
> I think [citation needed] each themes .plist file also includes a flag that says whether it's a good idea to have configurable backgrounds or not.
> Also if we just matched background colours if you have light coloured Chat Theme with dark KDE colours, us making a combined mix of them could look horrendous.
>
>  Ok, I get your point. It was a kind of test. In fact I wasn't even sure I could mess with the "main.css" file. Now that I think about it, you're right about the themes, if someone has a dark theme he/she should download a matching theme from audium and viceversa.
> Ok, delete this review.
>
>
> - Francesco
>
> On March 13th, 2011, 2:31 p.m., Francesco Nwokeka wrote:
>   Review request for Telepathy.
> By Francesco Nwokeka.
>
> *Updated March 13, 2011, 2:31 p.m.*
> Description
>
> Fix for bug 268281 @ https://bugs.kde.org/show_bug.cgi?id=268281
>
> the default color was set by the css that was "overwriting" any customization made by c++.
>
>   Testing
>
> Changed color of my kde theme and the chat window responded accordingly
>
>   Diffs
>
>    - data/styles/renkoo.AdiumMessageStyle/Contents/Resources/main.css
>    (c2ce2d5)
>    - lib/adium-theme-view.cpp (1eefafb)
>
> View Diff <http://git.reviewboard.kde.org/r/100849/diff/>
>
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110314/4ec0c204/attachment-0001.htm