Review Request: Fix bug 268281 - chat windows use theme colors

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100849/#review1932
-----------------------------------------------------------


You can't do it like this. Sorry.
We deliberately support pretty much every theme from the Adium website, therefore we can't  modify any theme code to make it fit what we want - as we'd have to do it for all of them which doesn't make sense.

Besides: Fully customisable background support is both planned and do-able.
I think [citation needed] each themes .plist file also includes a flag that says whether it's a good idea to have configurable backgrounds or not. 
Also if we just matched background colours if you have light coloured Chat Theme with dark KDE colours, us making a combined mix of them could look horrendous.

- David


On March 13, 2011, 2:31 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100849/
> -----------------------------------------------------------
> 
> (Updated March 13, 2011, 2:31 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Fix for bug 268281 @ https://bugs.kde.org/show_bug.cgi?id=268281
> 
> the default color was set by the css that was "overwriting" any customization made by c++.
> 
> 
> Diffs
> -----
> 
>   data/styles/renkoo.AdiumMessageStyle/Contents/Resources/main.css c2ce2d5 
>   lib/adium-theme-view.cpp 1eefafb 
> 
> Diff: http://git.reviewboard.kde.org/r/100849/diff
> 
> 
> Testing
> -------
> 
> Changed color of my kde theme and the chat window responded accordingly
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110313/59c24100/attachment.htm