Review Request: Created haze AIM plugin

[Florian Reinhard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100689/#review1921
-----------------------------------------------------------



haze/aim-main-options-widget.ui
<http://git.reviewboard.kde.org/r/100689/#comment1621>

    No need to use a QVBoxlayout wich just contains one item: a QFormLayout.



haze/aim-server-settings-widget.ui
<http://git.reviewboard.kde.org/r/100689/#comment1622>

    Use QFormLayout here.



haze/aim-server-settings-widget.ui
<http://git.reviewboard.kde.org/r/100689/#comment1618>

    maximum should be 65535



haze/aim-server-settings-widget.ui
<http://git.reviewboard.kde.org/r/100689/#comment1617>

    no need to provide a value here, default values are inserted automatically.



haze/haze-aim-account.cpp
<http://git.reviewboard.kde.org/r/100689/#comment1619>

    No need to use GenericAdvancedOptionsWidget here, just return aimServerSettingsWidget and you're good.
    
    That said you can drop the includes for GenericAdvancedOptionsWidget and KLocalizedString.



haze/yahoo-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100689/#comment1620>

    this shouldn't be here.


- Florian


On March 12, 2011, 2:10 p.m., Lasath Fernando wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100689/
> -----------------------------------------------------------
> 
> (Updated March 12, 2011, 2:10 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> I created a AIM plugin, with basic and advanced options in one go this time.
> 
> It's in my personal clone
> http://quickgit.kde.org/?p=clones/telepathy-accounts-kcm-plugins/fernando/main.git&a=shortlog&h=refs/heads/aol-plugin-build
> 
> (branch called 'aol-plugin-build')
> 
> 
> Diffs
> -----
> 
>   haze/aim-main-options-widget.cpp PRE-CREATION 
>   haze/aim-main-options-widget.h PRE-CREATION 
>   haze/CMakeLists.txt a998a65 
>   haze/aim-main-options-widget.ui PRE-CREATION 
>   haze/aim-server-settings-widget.h PRE-CREATION 
>   haze/aim-server-settings-widget.cpp PRE-CREATION 
>   haze/aim-server-settings-widget.ui PRE-CREATION 
>   haze/haze-account-ui-plugin.cpp 4854636 
>   haze/haze-aim-account.h PRE-CREATION 
>   haze/haze-aim-account.cpp PRE-CREATION 
>   haze/yahoo-main-options-widget.cpp 108a023 
> 
> Diff: http://git.reviewboard.kde.org/r/100689/diff
> 
> 
> Testing
> -------
> 
> Edited options and made sure they were reflected in Empathy.
> 
> 
> Thanks,
> 
> Lasath
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110312/a63bd8fb/attachment-0001.htm