Review Request: Fix bug 265422 : Make links clickable

[David Edmundson]

> On March 11, 2011, 1:34 a.m., David Edmundson wrote:
> > lib/adium-theme-view.cpp, line 317
> > <http://git.reviewboard.kde.org/r/100839/diff/1/?file=11107#file11107line317>
> >
> >     I think we might want to match "://" as part of the link.
> >     
> >     Otherwise this gets turned into a link:
> >     httpanyothertext
> >     
> >     Maybe "http(s?)://[^ \t\n\r\f\v]+" ?
> >     
> >
> 
> Martin Klapetek wrote:
>     What about emails and replacing them with mailto:email? Or also possibly ftp:// ? Though I"m not sure that you want to open this one in browser..

Definitely good ideas, might be easier to make them later commits (otherwise we'll never merge anything if we keep adding features).

For ftp:// smb:// etc, it would be worth getting these from KDE somehow instead of hardcoding it. I imagine there's something better than invokeBrowser (KRun?) if we get multiple different types.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100839/#review1894
-----------------------------------------------------------


On March 11, 2011, 1:23 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100839/
> -----------------------------------------------------------
> 
> (Updated March 11, 2011, 1:23 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Added a regex to search for http strings and replace them with a html link. The links are handled by us so the users default browser is invoked
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.h 6ba2af1 
>   lib/adium-theme-view.cpp acd3a38 
> 
> Diff: http://git.reviewboard.kde.org/r/100839/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110311/7506f49a/attachment.htm