Review Request: Fix bug 265422 : Make links clickable

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100839/#review1894
-----------------------------------------------------------



lib/adium-theme-view.h
<http://git.reviewboard.kde.org/r/100839/#comment1570>

    I don't think this is needed, you can connect directly to invokeBrowser



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/100839/#comment1574>

    #include <KToolInvocation>
    
    



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/100839/#comment1571>

    connect(this, SIGNAL(linkClicked(...,
            KToolInvocation::self(), SLOT(invokeBrowser(...)));



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/100839/#comment1572>

    deleted.



lib/adium-theme-view.cpp
<http://git.reviewboard.kde.org/r/100839/#comment1573>

    I think we might want to match "://" as part of the link.
    
    Otherwise this gets turned into a link:
    httpanyothertext
    
    Maybe "http(s?)://[^ \t\n\r\f\v]+" ?
    
    


- David


On March 11, 2011, 1:23 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100839/
> -----------------------------------------------------------
> 
> (Updated March 11, 2011, 1:23 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Added a regex to search for http strings and replace them with a html link. The links are handled by us so the users default browser is invoked
> 
> 
> Diffs
> -----
> 
>   lib/adium-theme-view.h 6ba2af1 
>   lib/adium-theme-view.cpp acd3a38 
> 
> Diff: http://git.reviewboard.kde.org/r/100839/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110311/4e449d7b/attachment.htm