Review Request: Implement unread messages in the lib and show the status in the app - v2

Francesco Nwokeka francesco.nwokeka at gmail.com
Thu Mar 10 16:04:11 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100820/#review1882
-----------------------------------------------------------

Ship it!


Looks ok to me.  Tried it out and minor "color" status bugs are fixed. Code is cool

- Francesco


On March 10, 2011, 3:14 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100820/
> -----------------------------------------------------------
> 
> (Updated March 10, 2011, 3:14 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Give an indication of the status of a chat (has unread messages/user is typing etc) via the colour of the text on the tab widget. 
> 
> A continuation of: https://git.reviewboard.kde.org/r/100594/
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt a1e4c61af852d28555af2e6ec537338e9f83c716 
>   app/chat-tab.h PRE-CREATION 
>   app/chat-tab.cpp PRE-CREATION 
>   app/chat-window.h e921d12d12b33b3937f8579c56cfee9474a3c2da 
>   app/chat-window.cpp 3ebe1c00a785399764bb004d253b766c3e6b4479 
>   app/telepathy-chat-ui.cpp 084589298708b30c947d582a7e5c0ad786d906f3 
>   lib/chat-widget.h ca24bc7f39224ebcbcf92f6a98229add9cddac10 
>   lib/chat-widget.cpp 48bf0b6294f08783720a97a44e45537042835bc6 
> 
> Diff: http://git.reviewboard.kde.org/r/100820/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110310/8321f4cf/attachment-0001.htm 


More information about the KDE-Telepathy mailing list