Review Request: Fix to avoid duplicate chat tabs

[Francesco Nwokeka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100825/
-----------------------------------------------------------

(Updated March 9, 2011, 6:52 p.m.)


Review request for Telepathy.


Changes
-------

Updated diff file with new changes asked for. Now the ChatWidget object is created only if it doesn't exist


Summary
-------

Simple patch to avoid creating duplicate chat tabs


Diffs (updated)
-----

  app/chat-window.h b023241 
  app/chat-window.cpp 66f7c03 
  app/telepathy-chat-ui.cpp 776c148 
  lib/chat-widget.h 95d4eb6 
  lib/chat-widget.cpp 753de62 

Diff: http://git.reviewboard.kde.org/r/100825/diff


Testing
-------

Tested it by adding three tabs and then requesting the same three tabs again. As expected i was show the already opened chat tab and no new tab was created.


Thanks,

Francesco

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110309/617a5bd2/attachment.htm