[Bug 265483] Close the channel when the tab is closed

[Olli Salli]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 07.03.2011 17:33, David Edmundson wrote:
> https://bugs.kde.org/show_bug.cgi?id=265483
> 
> 
> David Edmundson <kde at davidedmundson.co.uk> changed:
> 
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |kde at davidedmundson.co.uk
> 
> 
> 
> 
> --- Comment #4 from David Edmundson <kde davidedmundson co uk>  2011-03-07 16:33:24 ---
> I'm slightly worried about starting an async method on the channel object, and
> then immediately deleting it before we know it's finished. Potentially that
> will result in something that doesn't always close or worse crashes.
> 
> We quite possibly want to wait for the requestClose/requestLeave to finish
> before we delete it.
> 
> Will check the source code for Tp-Qt4 tonight, and then see what's safe.
> 

Sorry, I don't think I have a KDE bugzilla account (or can't remember
the passwd) so I'll comment here.

It's always perfectly safe to do this in tp-qt4-0.5! We identified
calling some operation and then just forgetting about the object as a
very frequently recurring pitfall in pre-0.5, so we made every
PendingOperation ref the "context" object they need (in the case of
requestClose, that is the Channel) until they finish.

Br,
Olli Salli
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNdPsxAAoJEAQQkupGanj4tQEIAKxX0NZ1sH7kMguDqwuaGbG2
kf03N3nONCEldUdAZkG9CF1eWckf9EpyijcvT3PDsW6GTpn1SWGtetnECmyNpWMc
S3QRFeoqeasdgW3+PHaqPzaS9Gn+8nOGSBGtOcBW1iwTbUSeVB56nMCbtdGMMaAS
2nIYEM/Ns5aWo0UIxZExtOOm9lDahrpbQETprmGYpk4wTkdzpU8PkVfd9RZhh4U9
0uwURmwNe+mwnUdVZYyhWU4tXM7DDhu5IX4d7MQE5AMQVWaG5JxUGQe3+QNJ+NPT
iI/H5ZXCs5STwx1yoLhwombltFHw3CLTI1CxTCN8kMkpLk5IvOPLKHxq5BwbXMo=
=RKy5
-----END PGP SIGNATURE-----