Review Request: add autocomplete for skype account names
David Edmundson
kde at davidedmundson.co.uk
Thu Mar 3 14:44:39 CET 2011
> On March 3, 2011, 1:42 p.m., David Edmundson wrote:
> > haze/skype-main-options-widget.cpp, line 47
> > <http://git.reviewboard.kde.org/r/100775/diff/2/?file=10509#file10509line47>
> >
> > This won't compile.
> >
> > skypeConfigDir->entryInfoList(....
> > should now be
> > skypeConifgDir.entryInfoList(...
> >
> > as you changed it from QDir* to QDir.
except with skypeConfigDir still spelt correctly of course.
- David
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100775/#review1747
-----------------------------------------------------------
On March 3, 2011, 1:36 p.m., Florian Reinhard wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100775/
> -----------------------------------------------------------
>
> (Updated March 3, 2011, 1:36 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> * add autocomplete for skype account names based on foldernames in $HOME/.Skype/
>
>
> Diffs
> -----
>
> haze/skype-main-options-widget.cpp 572804f178bc5f3646483adc0a8337470d5ca168
>
> Diff: http://git.reviewboard.kde.org/r/100775/diff
>
>
> Testing
> -------
>
> * works with two accounts in ~/.Skype/
> * does nothing if there is no ~/.Skype/
>
>
> Thanks,
>
> Florian
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110303/350016a7/attachment.htm
More information about the KDE-Telepathy
mailing list