Review Request: bigbrownchunx-skype-dbus (skype) protocol support for haze kcm plugin

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100774/#review1721
-----------------------------------------------------------

Ship it!


I would recommend (as a different commit) adding an entry into dictionary.cpp of the accounts KCM so that this appears as "Skype" rather than "bigbrownchunx"

- David


On March 1, 2011, 1:16 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100774/
> -----------------------------------------------------------
> 
> (Updated March 1, 2011, 1:16 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Adds support for bigbrownchunx-skype-dbus "protocol" to the haze kcm plugin.
> 
> You will needs pidgin-skype installed to test it.
> 
> 
> Diffs
> -----
> 
>   haze/CMakeLists.txt 67d43a1b278b82dfc203646145e8ddaabf23f62f 
>   haze/haze-account-ui-plugin.cpp 5cebd1a356f6d9f34e12da869b942218e2263af3 
>   haze/haze-skype-account-ui.h PRE-CREATION 
>   haze/haze-skype-account-ui.cpp PRE-CREATION 
>   haze/skype-advanced-settings-widget.h PRE-CREATION 
>   haze/skype-advanced-settings-widget.cpp PRE-CREATION 
>   haze/skype-advanced-settings-widget.ui PRE-CREATION 
>   haze/skype-main-options-widget.h PRE-CREATION 
>   haze/skype-main-options-widget.cpp PRE-CREATION 
>   haze/skype-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100774/diff
> 
> 
> Testing
> -------
> 
> * add account
> * connect
> 
> 
> Screenshots
> -----------
> 
> main and advanced options
>   http://git.reviewboard.kde.org/r/100774/s/88/
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110301/fa73c1b1/attachment.htm