Review Request: Add "join chat room" action in contact list

[Martin Klapetek]

> On June 27, 2011, 8:39 a.m., Martin Klapetek wrote:
> > Is the wrench button the right place to place "Join chat room" button/menu item? Because that wrench is for settings and thus only settings should go there, it doesn't make sense to have "Join chat room" there.
> 
> Francesco Nwokeka wrote:
>     I can move it out with the other toolbuttons. I put it under the wrench to avoid cluttering up the ui with buttons. What do you say?

Yeah, I figured that's why you put it there :) I think we can move some other button under settings and put the Join button instead of that one. Opinions (all)?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101751/#review4192
-----------------------------------------------------------


On June 24, 2011, 9:43 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101751/
> -----------------------------------------------------------
> 
> (Updated June 24, 2011, 9:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Adds an action under the "wrench" button to join a chat group. Only online accounts with this capability are listed.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 3dd8cc0 
>   dialogs/join-chat-room-dialog.h PRE-CREATION 
>   dialogs/join-chat-room-dialog.cpp PRE-CREATION 
>   main-widget.h 5625778 
>   main-widget.cpp f19cbee 
> 
> Diff: http://git.reviewboard.kde.org/r/101751/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110628/ca5517d1/attachment.htm