Review Request: Fix Bug 270717 : Page Down and Page Up don't scroll the chat area
Lasath Fernando
kde at lasath.org
Sat Jun 25 14:30:47 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101757/
-----------------------------------------------------------
(Updated June 25, 2011, 12:30 p.m.)
Review request for Telepathy.
Changes
-------
Made suggested changes.
Summary
-------
Created a new signal in ChatTextEdit and a new slot in AdiumThemeView.
Used them to proxy the QKeyEvents for Page Up and Page Down to chatArea.
This addresses bug https://bugs.kde.org/show_bug.cgi?id=270717.
http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=270717
Diffs (updated)
-----
app/chat-window.cpp 0e6094a
lib/adium-theme-view.h d7c6cb2
lib/adium-theme-view.cpp 2211cfa
lib/chat-text-edit.h 4f553da
lib/chat-text-edit.cpp 4c3a4c0
lib/chat-widget.h 06e98a1
lib/chat-widget.cpp 89e8c97
Diff: http://git.reviewboard.kde.org/r/101757/diff
Testing
-------
Chatted with a friend.
Hit PgUp/Down.
Thanks,
Lasath
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110625/8fbb61d2/attachment.htm
More information about the KDE-Telepathy
mailing list