Review Request: Add "join chat room" action in contact list
David Edmundson
kde at davidedmundson.co.uk
Fri Jun 24 23:47:31 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101751/#review4135
-----------------------------------------------------------
One thing to fix that I failed to spot last time.
Then I'm happy with it.
dialogs/join-chat-room-dialog.cpp
<http://git.reviewboard.kde.org/r/101751/#comment3394>
This gets leaked.
- David
On June 24, 2011, 9:43 p.m., Francesco Nwokeka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101751/
> -----------------------------------------------------------
>
> (Updated June 24, 2011, 9:43 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Adds an action under the "wrench" button to join a chat group. Only online accounts with this capability are listed.
>
>
> Diffs
> -----
>
> CMakeLists.txt 3dd8cc0
> dialogs/join-chat-room-dialog.h PRE-CREATION
> dialogs/join-chat-room-dialog.cpp PRE-CREATION
> main-widget.h 5625778
> main-widget.cpp f19cbee
>
> Diff: http://git.reviewboard.kde.org/r/101751/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Francesco
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110624/474e8449/attachment.htm
More information about the KDE-Telepathy
mailing list