Review Request: Only list audio/video/file capability on a contact if selfContact can support it.

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Fri Jun 24 10:19:24 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101729/#review4115
-----------------------------------------------------------

Ship it!


Looks good now!

- Daniele Elmo


On June 23, 2011, 11:20 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101729/
> -----------------------------------------------------------
> 
> (Updated June 23, 2011, 11:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Only list audio/video/file capability on a contact if selfContact can support it.
> 
> 
> Diffs
> -----
> 
>   models/contact-model-item.cpp PRE-CREATION 
>   models/tree-node.h PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101729/diff
> 
> 
> Testing
> -------
> 
> Opened contact list, checked that I don't have audio/video listed without KCall installed. 
> Same code was used in the chat window apparently file transfer listing works too.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110624/1ec060b8/attachment.htm 


More information about the KDE-Telepathy mailing list