Review Request: Only list audio/video/file capability on a contact if selfContact can support it.

Thu Jun 23 01:30:44 CEST 2011

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101729/#review4083
-----------------------------------------------------------


contact-model-item.cpp
<http://git.reviewboard.kde.org/r/101729/#comment3326>

    I don't know if they can change, but perhaps you should connect also capabilitiesChanged from self contact...


contact-model-item.cpp
<http://git.reviewboard.kde.org/r/101729/#comment3327>

    Is there a reason why you are not using mPriv->mContact->capabilities().fileTransfer() here?


- Daniele Elmo


On June 22, 2011, 7:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101729/
> -----------------------------------------------------------
> 
> (Updated June 22, 2011, 7:38 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Only list audio/video/file capability on a contact if selfContact can support it.
> 
> 
> Diffs
> -----
> 
>   contact-model-item.h 772becdfd1b98a51e1adfc815485b17e5256b851 
>   contact-model-item.cpp f9fb80d065a958682a6bc58e510dc975ee518fc8 
> 
> Diff: http://git.reviewboard.kde.org/r/101729/diff
> 
> 
> Testing
> -------
> 
> Opened contact list, checked that I don't have audio/video listed without KCall installed. 
> Same code was used in the chat window apparently file transfer listing works too.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110622/150f7555/attachment.htm