Review Request: Get rid of double call to remove() in proxy-tree-node remove is called eventually on the node through "emit childrenRemoved()"

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101724/#review4067
-----------------------------------------------------------

Ship it!


- Martin


On June 22, 2011, 12:45 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101724/
> -----------------------------------------------------------
> 
> (Updated June 22, 2011, 12:45 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Get rid of double call to remove() in proxy-tree-node remove is called eventually on the node through "emit childrenRemoved()"
> 
> 
> Diffs
> -----
> 
>   proxy-tree-node.cpp 3a5dae550b151136cb1db37b621878c7b56c1466 
> 
> Diff: http://git.reviewboard.kde.org/r/101724/diff
> 
> 
> Testing
> -------
> 
> Loaded contact list, disabled some accounts with groups enabled. Checked contacts disappeared and the CL didn't crash.
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110622/9f962323/attachment.htm