Review Request: Get rid of double call to remove() in proxy-tree-node remove is called eventually on the node through "emit childrenRemoved()"

David Edmundson kde at davidedmundson.co.uk
Wed Jun 22 14:45:10 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101724/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Get rid of double call to remove() in proxy-tree-node remove is called eventually on the node through "emit childrenRemoved()"


Diffs
-----

  proxy-tree-node.cpp 3a5dae550b151136cb1db37b621878c7b56c1466 

Diff: http://git.reviewboard.kde.org/r/101724/diff


Testing
-------

Loaded contact list, disabled some accounts with groups enabled. Checked contacts disappeared and the CL didn't crash.


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110622/719db2df/attachment.htm 


More information about the KDE-Telepathy mailing list