Review Request: Use proper Account/Groups checking

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Sat Jun 18 01:52:31 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101663/#review3980
-----------------------------------------------------------

Ship it!


- Daniele Elmo


On June 17, 2011, 11:03 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101663/
> -----------------------------------------------------------
> 
> (Updated June 17, 2011, 11:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Use comparing of QVariant::userType() and qMetaTypeId instead of checking an empty alias. Rest of the code should be already clear of this.
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp 27a903d 
> 
> Diff: http://git.reviewboard.kde.org/r/101663/diff
> 
> 
> Testing
> -------
> 
> Works as expected.
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110617/e412e465/attachment.htm 


More information about the KDE-Telepathy mailing list