Review Request: single click to expand groups in contact list

[David Edmundson]

On Fri, Jun 17, 2011 at 11:10 PM, Martin Klapetek
<martin.klapetek at gmail.com> wrote:
> It's actually wrong as it should check for the type being
> GroupsModelItem or AccountsModelItem (same for dbl click), not for
> empty alias :)

Totally agree, but that's what the old code had, so it's sort of a new patch.

There's another instance of it somewhere in the CL IIRC, they all need fixing.
>
> --Marty
>
> On Friday, June 17, 2011, Commit Hook <null at kde.org> wrote:
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>       This is an automatically generated e-mail. To reply, visit:
>>       http://git.reviewboard.kde.org/r/101662/
>>
>>
>>
>>
>>  This review has been submitted with commit b83e452e60969ee02891db835c715a88fac391db by Francesco Nwokeka to branch master.
>>
>> - Commit
>>
>>
>>
>> On June 17th, 2011, 8:57 p.m., Francesco Nwokeka wrote:
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> Review request for Telepathy.
>> By Francesco Nwokeka.
>>
>>
>> Updated June 17, 2011, 8:57 p.m.
>>
>>
>>
>>
>> Description
>>
>>
>>
>>    Groups expand on single click + some code optimization
>>
>>
>>
>>
>>
>>
>>
>>
>>  Bugs:
>>
>>
>>  275413 <http://bugs.kde.org/show_bug.cgi?id=275413>
>>
>>
>>
>>
>>
>> Diffs
>>
>>
>>  main-widget.h (070ac10)
>>
>>  main-widget.cpp (bdec5ab)
>>
>>
>>
>> View Diff <http://git.reviewboard.kde.org/r/101662/diff/>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>
> --
> --Marty
> _______________________________________________
> KDE-Telepathy mailing list
> KDE-Telepathy at kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy
>