Review Request: add new toolbuttons to chat part 3of3

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101645/#review3936
-----------------------------------------------------------

Ship it!


Pretty much perfect. 

I would like to see this tested before we commit as we're not entirely sure this selfContact thing works. Ideally properly by uninstalling the file transfer handler on our local machine restarting MC and see if the button is now disabled. Then re-install and check it comes back.

I can do that last part if you want.



app/chat-window.h
<http://git.reviewboard.kde.org/r/101645/#comment3212>

    Add your name here.



app/chat-window.cpp
<http://git.reviewboard.kde.org/r/101645/#comment3211>

    don't call this accountCapabilities. The whole situation got confusing enough as it was.
    
    account and self are completely different.
    
    selfCapabilities would be better.


- David


On June 16, 2011, 6:35 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101645/
> -----------------------------------------------------------
> 
> (Updated June 16, 2011, 6:35 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This final patch activates/de-activates the toolbuttons accounding to whether both account and contact can preform the action expressed by the toolbar button. 
> 
> 
> Diffs
> -----
> 
>   app/chat-window.h 661cbea 
>   app/chat-window.cpp b5b8b7a 
> 
> Diff: http://git.reviewboard.kde.org/r/101645/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110616/94b9df05/attachment-0001.htm